Thanks for the interesting Kata. Used to write JS like C. Now learned new JS features.
This comment is hidden because it contains spoiler information about the solution
I guess there is some mistake in the last example in 'Test Reuse lazy filterNumbers + filterRange + max function' section. I understood it when I was exploring the output. I realized that it is as in the description, but the correct result is different. I mean, in the description '6' is received but in the example '1'. Can you fix it or explain me what I understood wrong?
When you implement dynamic programming correctly but your implementation still runs too slowly xD. Argh!
It would be nice if there were unit tests
I got it!
Could just be coincidence, but this is a copy of a problem from Project Euler (https://projecteuler.net/problem=76) - consider giving credit on details page?
Node 12.x enabled without updating all tests. Hopefully it's futureproof.
First 1kyu task)
To anyone seeing this comment.
Memoization will be helpful to make the code run without exploding. BUT, it will not solve the computation. You still need to figure out how to compute it :)
The kata requires you to throw an error but codewars doesn't let me submit my code if it throws errors
And is that an issue of the kata or your code?
I pass all the tests but can't submit because of the errors (the ones that you are required to throw for the kata).
Never mind. I figured out my error. But it seems the the message is misleading and it flippled the "Expected" and "Instead got".
This is a fun kata and it really helped me refresh my knowledge about the BST.
I can't figure out why I can't pass this test for toArray [ 8, 6, 15, 2, 7, 10, 23, 1, 4, 6, 7, 8, 10, 20, undefined, 1, 1, 3 ] in the attempt.
The error message I got was:
Expected: '[1, 1, 1, 2, 3, 4, 6, 6, 7, 7, 8, 8, 10, 10, 15, 20, 23]', instead got: '[1, 1, 1, 2, 3, 4, 5, 6, 6, 7, 7, 8, 8, 10, 10, 15, 20, 23]'
I printed out my result right before I return it and actually got the correct result. It's mysterious where that extra "5" comes from. I even tried just returning the expected result as the only statement in the function, and it still gives me the same error for that test.
Does anyone got the same issue or is it just me?